Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BannerNotification mutations #919

Merged
merged 9 commits into from
Aug 31, 2023
Merged

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Aug 30, 2023

Change log

  • Adds banner notification mutations
  • Adds new mutation base classes (to make development easier in the future)
  • Renames BannerNotification .type to .level due to a bug in graphene

Jira Issue: TILA-1588

See issue with using type as a name with mutations:
graphql-python/graphene#1519
@matti-lamppu matti-lamppu changed the title [WIP] Rename BannerNotification type to level [WIP] Add BannerNotification mutations Aug 30, 2023
@matti-lamppu matti-lamppu marked this pull request as ready for review August 31, 2023 07:50
@matti-lamppu matti-lamppu changed the title [WIP] Add BannerNotification mutations Add BannerNotification mutations Aug 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.5% 95.5% Coverage
0.0% 0.0% Duplication

@matti-lamppu matti-lamppu merged commit 91dae62 into main Aug 31, 2023
5 checks passed
@matti-lamppu matti-lamppu deleted the banner-notification-mutations branch August 31, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants